refactor(test-loop): make enable_rpc work for both setup APIs (2/6)#15937
Open
darioush wants to merge 1 commit into
Open
refactor(test-loop): make enable_rpc work for both setup APIs (2/6)#15937darioush wants to merge 1 commit into
darioush wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## darioush/spice/all-stake-fallback-1 #15937 +/- ##
=======================================================================
- Coverage 72.63% 72.63% -0.01%
=======================================================================
Files 953 953
Lines 205254 205257 +3
Branches 205254 205257 +3
=======================================================================
- Hits 149091 149087 -4
- Misses 51185 51194 +9
+ Partials 4978 4976 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the test-loop setup builder so enable_rpc() consistently adds a dedicated non-validator “RPC” node (tracking all shards) regardless of whether tests use the auto-derived setup API or the manual .genesis()/.clients() API.
Changes:
- Hoists
enable_rpcfromAutoSetupConfigintoTestLoopBuilder. - Applies
enable_rpccentrally inresolve_setup_config()by appending anrpc_account_id()client after the setup config resolves. - Simplifies auto-setup client list creation by removing the
validators_spec_clients_with_rpcbranching.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
darioush
changed the title
darioush
changed the title
darioush
force-pushed
the
darioush/spice/all-stake-fallback-1
branch
from
5c85509 to
7de80be
Compare
darioush
force-pushed
the
darioush/test-loop/hoist-enable-rpc
branch
from
dee2cae to
d859b1a
Compare
pugachAG
approved these changes
Jun 26, 2026
pugachAG
left a comment
pugachAG
left a comment
Contributor
There was a problem hiding this comment.
nit: seems like this doesn't need to be a part of the PR stack and can be merged independently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoists
enable_rpcfromAutoSetupConfig(auto/new API only) up toTestLoopBuilder, applying it inresolve_setup_configafter the setup config resolves. The non-validator RPC node is now appended regardless of whether the test used the auto or the manual setup API.